Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
L
libpciaccess
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
staging
rpms
libpciaccess
Commits
94f6702a
Commit
94f6702a
authored
11 months ago
by
Rocky Automation
Browse files
Options
Downloads
Patches
Plain Diff
import libpciaccess-0.16-14.el10
parent
7dd0536b
No related branches found
Branches containing commit
Tags
imports/r10s/libpciaccess-0.16-15.el10
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
SOURCES/0001-vgaarb-Check-snprintf-return-value.patch
+69
-0
69 additions, 0 deletions
SOURCES/0001-vgaarb-Check-snprintf-return-value.patch
SPECS/libpciaccess.spec
+9
-1
9 additions, 1 deletion
SPECS/libpciaccess.spec
with
78 additions
and
1 deletion
SOURCES/0001-vgaarb-Check-snprintf-return-value.patch
0 → 100644
+
69
−
0
View file @
94f6702a
From c4af0f3ab992977d7fde65240a15481a1adc859c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= <jexposit@redhat.com>
Date: Tue, 19 Mar 2024 13:45:19 +0100
Subject: [PATCH] vgaarb: Check snprintf return value
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
snprintf() might return a negative value if an error occurs.
Check its return value before using it in vgaarb_write().
Signed-off-by: José Expósito <jexposit@redhat.com>
---
src/common_vgaarb.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/src/common_vgaarb.c b/src/common_vgaarb.c
index 515275f..a1edfab 100644
--- a/src/common_vgaarb.c
+++ b/src/common_vgaarb.c
@@ -238,6 +238,8 @@
pci_device_vgaarb_set_target(struct pci_device *dev)
len = snprintf(buf, BUFSIZE, "target PCI:%04x:%02x:%02x.%x",
dev->domain, dev->bus, dev->dev, dev->func);
+ if (len < 0 || len >= BUFSIZE)
+ return -1;
ret = vgaarb_write(pci_sys->vgaarb_fd, buf, len);
if (ret)
@@ -268,6 +270,9 @@
pci_device_vgaarb_decodes(int new_vgaarb_rsrc)
return 0;
len = snprintf(buf, BUFSIZE, "decodes %s", rsrc_to_str(new_vgaarb_rsrc));
+ if (len < 0 || len >= BUFSIZE)
+ return -1;
+
ret = vgaarb_write(pci_sys->vgaarb_fd, buf, len);
if (ret == 0)
dev->vgaarb_rsrc = new_vgaarb_rsrc;
@@ -297,6 +302,8 @@
pci_device_vgaarb_lock(void)
return 0;
len = snprintf(buf, BUFSIZE, "lock %s", rsrc_to_str(dev->vgaarb_rsrc));
+ if (len < 0 || len >= BUFSIZE)
+ return -1;
return vgaarb_write(pci_sys->vgaarb_fd, buf, len);
}
@@ -315,6 +322,8 @@
pci_device_vgaarb_trylock(void)
return 0;
len = snprintf(buf, BUFSIZE, "trylock %s", rsrc_to_str(dev->vgaarb_rsrc));
+ if (len < 0 || len >= BUFSIZE)
+ return -1;
return vgaarb_write(pci_sys->vgaarb_fd, buf, len);
}
@@ -333,6 +342,8 @@
pci_device_vgaarb_unlock(void)
return 0;
len = snprintf(buf, BUFSIZE, "unlock %s", rsrc_to_str(dev->vgaarb_rsrc));
+ if (len < 0 || len >= BUFSIZE)
+ return -1;
return vgaarb_write(pci_sys->vgaarb_fd, buf, len);
}
--
2.44.0
This diff is collapsed.
Click to expand it.
SPECS/libpciaccess.spec
+
9
−
1
View file @
94f6702a
Name: libpciaccess
Version: 0.16
Release: 1
2
%{?dist}
Release: 1
4
%{?dist}
Summary: PCI access library
License: HPND AND MIT
...
...
@@ -13,6 +13,7 @@ Source0: https://www.x.org/archive/individual/lib/%{name}-%{version}.tar.bz2
Source1: make-libpciaccess-snapshot.sh
Patch2: libpciaccess-rom-size.patch
Patch3: 0001-vgaarb-Check-snprintf-return-value.patch
BuildRequires: autoconf automake libtool pkgconfig xorg-x11-util-macros
BuildRequires: make
...
...
@@ -56,6 +57,13 @@ rm -f $RPM_BUILD_ROOT/%{_libdir}/*.la
%{_libdir}/pkgconfig/pciaccess.pc
%changelog
* Wed Mar 20 2024 José Expósito <jexposit@redhat.com> - 0.16-14
- Add gating.yaml
* Wed Mar 20 2024 José Expósito <jexposit@redhat.com> - 0.16-13
- Fix findings from static application security testing (SAST)
Resolves: https://issues.redhat.com/browse/RHEL-29742
* Thu Jan 25 2024 Fedora Release Engineering <releng@fedoraproject.org> - 0.16-12
- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment