smb: client: fix chmod(2) regression with ATTR_READONLY

JIRA: https://issues.redhat.com/browse/RHEL-82677
Y-JIRA: https://issues.redhat.com/browse/RHEL-80534
Y-Commit: ff607656

O-JIRA: https://issues.redhat.com/browse/RHEL-80534



commit 654292a0b264e9b8c51b98394146218a21612aa1
Author: Paulo Alcantara <pc@manguebit.com>
Date:   Sun Feb 16 18:02:47 2025 -0300

    smb: client: fix chmod(2) regression with ATTR_READONLY

    When the user sets a file or directory as read-only (e.g. ~S_IWUGO),
    the client will set the ATTR_READONLY attribute by sending an
    SMB2_SET_INFO request to the server in cifs_setattr_{,nounix}(), but
    cifsInodeInfo::cifsAttrs will be left unchanged as the client will
    only update the new file attributes in the next call to
    {smb311_posix,cifs}_get_inode_info() with the new metadata filled in
    @data parameter.

    Commit a18280e7 ("smb: cilent: set reparse mount points as
    automounts") mistakenly removed the @data NULL check when calling
    is_inode_cache_good(), which broke the above case as the new
    ATTR_READONLY attribute would end up not being updated on files with a
    read lease.

    Fix this by updating the inode whenever we have cached metadata in
    @data parameter.

Reported-by: Horst Reiterer <horst.reiterer@fabasoft.com>
    Closes: https://lore.kernel.org/r/85a16504e09147a195ac0aac1c801280@fabasoft.com


    Fixes: a18280e7 ("smb: cilent: set reparse mount points as automounts")
    Cc: stable@vger.kernel.org
Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

Signed-off-by: Paulo Alcantara <paalcant@redhat.com>

Signed-off-by: Jay Shin <jaeshin@redhat.com>