Skip to content
Snippets Groups Projects
Commit eebd6143 authored by Myron Stowe's avatar Myron Stowe
Browse files

PCI: mediatek-gen3: Rely on msleep() in mtk_pcie_en7581_power_up()

JIRA: https://issues.redhat.com/browse/RHEL-83611
Upstream Status: c98bee18d0a094e37100c85effe5e161418f8644

commit c98bee18d0a094e37100c85effe5e161418f8644
Author: Lorenzo Bianconi <lorenzo@kernel.org>
Date:   Wed Jan 8 10:50:44 2025 +0100

    PCI: mediatek-gen3: Rely on msleep() in mtk_pcie_en7581_power_up()

    Since mtk_pcie_en7581_power_up() runs in non-atomic context, rely on
    msleep() routine instead of mdelay().

    Link: https://lore.kernel.org/r/20250108-pcie-en7581-fixes-v6-5-21ac939a3b9b@kernel.org


Signed-off-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Signed-off-by: default avatarMyron Stowe <mstowe@redhat.com>
parent d4c63c31
No related branches found
No related tags found
No related merge requests found
...@@ -923,7 +923,7 @@ static int mtk_pcie_en7581_power_up(struct mtk_gen3_pcie *pcie) ...@@ -923,7 +923,7 @@ static int mtk_pcie_en7581_power_up(struct mtk_gen3_pcie *pcie)
reset_control_assert(pcie->mac_reset); reset_control_assert(pcie->mac_reset);
/* Wait for the time needed to complete the reset lines assert. */ /* Wait for the time needed to complete the reset lines assert. */
mdelay(PCIE_EN7581_RESET_TIME_MS); msleep(PCIE_EN7581_RESET_TIME_MS);
/* /*
* Unlike the other MediaTek Gen3 controllers, the Airoha EN7581 * Unlike the other MediaTek Gen3 controllers, the Airoha EN7581
...@@ -951,7 +951,7 @@ static int mtk_pcie_en7581_power_up(struct mtk_gen3_pcie *pcie) ...@@ -951,7 +951,7 @@ static int mtk_pcie_en7581_power_up(struct mtk_gen3_pcie *pcie)
* Wait for the time needed to complete the bulk de-assert above. * Wait for the time needed to complete the bulk de-assert above.
* This time is specific for EN7581 SoC. * This time is specific for EN7581 SoC.
*/ */
mdelay(PCIE_EN7581_RESET_TIME_MS); msleep(PCIE_EN7581_RESET_TIME_MS);
pm_runtime_enable(dev); pm_runtime_enable(dev);
pm_runtime_get_sync(dev); pm_runtime_get_sync(dev);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment