Skip to content
  • Arnd Bergmann's avatar
    52518e51
    media: rc: clean up Kconfig dependencies · 52518e51
    Arnd Bergmann authored
    
    
    I came across a randconfig build failure from one driver
    that only depends on CONFIG_USB_ARCH_HAS_HCD but fails when
    built without CONFIG_USB:
    
    ld: drivers/media/rc/ir_toy.o: in function `irtoy_disconnect':
    ir_toy.c:(.text+0x24): undefined reference to `usb_kill_urb'
    ld: ir_toy.c:(.text+0x2c): undefined reference to `usb_free_urb'
    ld: ir_toy.c:(.text+0x34): undefined reference to `usb_kill_urb'
    ld: ir_toy.c:(.text+0x3c): undefined reference to `usb_free_urb'
    
    Upon a closer look, I find that a lot of the other drivers
    'select USB' rather than stating 'depends on USB' as is common
    for most subsystems. I also find that all except one driver
    have an extra 'depends on RC_CORE' that is already implied by
    the top-level 'if RC_CORE' check.
    
    Clean up both by reducing the dependencies to the required set.
    
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-by: default avatarRandy Dunlap <rdunlap@infradead.org>
    Signed-off-by: default avatarSean Young <sean@mess.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
    52518e51
    media: rc: clean up Kconfig dependencies
    Arnd Bergmann authored
    
    
    I came across a randconfig build failure from one driver
    that only depends on CONFIG_USB_ARCH_HAS_HCD but fails when
    built without CONFIG_USB:
    
    ld: drivers/media/rc/ir_toy.o: in function `irtoy_disconnect':
    ir_toy.c:(.text+0x24): undefined reference to `usb_kill_urb'
    ld: ir_toy.c:(.text+0x2c): undefined reference to `usb_free_urb'
    ld: ir_toy.c:(.text+0x34): undefined reference to `usb_kill_urb'
    ld: ir_toy.c:(.text+0x3c): undefined reference to `usb_free_urb'
    
    Upon a closer look, I find that a lot of the other drivers
    'select USB' rather than stating 'depends on USB' as is common
    for most subsystems. I also find that all except one driver
    have an extra 'depends on RC_CORE' that is already implied by
    the top-level 'if RC_CORE' check.
    
    Clean up both by reducing the dependencies to the required set.
    
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-by: default avatarRandy Dunlap <rdunlap@infradead.org>
    Signed-off-by: default avatarSean Young <sean@mess.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Loading