Skip to content
Snippets Groups Projects
Commit 1abff6be authored by Myron Stowe's avatar Myron Stowe
Browse files

PCI: mediatek-gen3: Add comment about initialization order in mtk_pcie_en7581_power_up()

JIRA: https://issues.redhat.com/browse/RHEL-83611
Upstream Status: 0c9d2d2ef0d916b490a9222ed20ff4616fca876d

commit 0c9d2d2ef0d916b490a9222ed20ff4616fca876d
Author: Lorenzo Bianconi <lorenzo@kernel.org>
Date:   Wed Jan 8 10:50:42 2025 +0100

    PCI: mediatek-gen3: Add comment about initialization order in mtk_pcie_en7581_power_up()

    Add a comment in mtk_pcie_en7581_power_up() to clarify, unlike the other
    MediaTek Gen3 controllers, the Airoha EN7581 requires PHY initialization
    and power-on before PHY reset deassert.

    Link: https://lore.kernel.org/r/20250108-pcie-en7581-fixes-v6-3-21ac939a3b9b@kernel.org


Signed-off-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Signed-off-by: default avatarMyron Stowe <mstowe@redhat.com>
parent c5301b53
No related branches found
No related tags found
No related merge requests found
......@@ -925,6 +925,10 @@ static int mtk_pcie_en7581_power_up(struct mtk_gen3_pcie *pcie)
/* Wait for the time needed to complete the reset lines assert. */
mdelay(PCIE_EN7581_RESET_TIME_MS);
/*
* Unlike the other MediaTek Gen3 controllers, the Airoha EN7581
* requires PHY initialization and power-on before PHY reset deassert.
*/
err = phy_init(pcie->phy);
if (err) {
dev_err(dev, "failed to initialize PHY\n");
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment